dma-buf: Return error instead of using a goto statement when possible Remove an error label in dma_buf_attach() that just returns an error code. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> Signed-off-by: Sumit Semwal <sumit.semwal@linaro.org>
diff --git a/drivers/base/dma-buf.c b/drivers/base/dma-buf.c index 198edd8..97450a5 100644 --- a/drivers/base/dma-buf.c +++ b/drivers/base/dma-buf.c
@@ -190,7 +190,7 @@ attach = kzalloc(sizeof(struct dma_buf_attachment), GFP_KERNEL); if (attach == NULL) - goto err_alloc; + return ERR_PTR(-ENOMEM); mutex_lock(&dmabuf->lock); @@ -206,8 +206,6 @@ mutex_unlock(&dmabuf->lock); return attach; -err_alloc: - return ERR_PTR(-ENOMEM); err_attach: kfree(attach); mutex_unlock(&dmabuf->lock);