drivers/gpu/drm/exynos/exynos_drm_connector.c - linux - Git at Google

 /*
  * Copyright (c) 2011 Samsung Electronics Co., Ltd.
  * Authors:
  *	Inki Dae <inki.dae@samsung.com>
  *	Joonyoung Shim <jy0922.shim@samsung.com>
  *	Seung-Woo Kim <sw0312.kim@samsung.com>
  *
  * This program is free software; you can redistribute  it and/or modify it
  * under  the terms of  the GNU General  Public License as published by the
  * Free Software Foundation;  either version 2 of the  License, or (at your
  * option) any later version.
  */

 #include <drm/drmP.h>
 #include <drm/drm_crtc_helper.h>

 #include <drm/exynos_drm.h>
 #include "exynos_drm_drv.h"
 #include "exynos_drm_encoder.h"

 #define to_exynos_connector(x)	container_of(x, struct exynos_drm_connector,\
 				drm_connector)

 struct exynos_drm_connector {
 	struct drm_connector	drm_connector;
 	uint32_t		encoder_id;
 	struct exynos_drm_manager *manager;
 	uint32_t		dpms;
 };

 /* convert exynos_video_timings to drm_display_mode */
 static inline void
 convert_to_display_mode(struct drm_display_mode *mode,
 			struct exynos_drm_panel_info *panel)
 {
 	struct fb_videomode *timing = &panel->timing;
 	DRM_DEBUG_KMS("%s\n", __FILE__);

 	mode->clock = timing->pixclock / 1000;
 	mode->vrefresh = timing->refresh;

 	mode->hdisplay = timing->xres;
 	mode->hsync_start = mode->hdisplay + timing->right_margin;
 	mode->hsync_end = mode->hsync_start + timing->hsync_len;
 	mode->htotal = mode->hsync_end + timing->left_margin;

 	mode->vdisplay = timing->yres;
 	mode->vsync_start = mode->vdisplay + timing->lower_margin;
 	mode->vsync_end = mode->vsync_start + timing->vsync_len;
 	mode->vtotal = mode->vsync_end + timing->upper_margin;
 	mode->width_mm = panel->width_mm;
 	mode->height_mm = panel->height_mm;

 	if (timing->vmode & FB_VMODE_INTERLACED)
 		mode->flags |= DRM_MODE_FLAG_INTERLACE;

 	if (timing->vmode & FB_VMODE_DOUBLE)
 		mode->flags |= DRM_MODE_FLAG_DBLSCAN;
 }

 /* convert drm_display_mode to exynos_video_timings */
 static inline void
 convert_to_video_timing(struct fb_videomode *timing,
 			struct drm_display_mode *mode)
 {
 	DRM_DEBUG_KMS("%s\n", __FILE__);

 	memset(timing, 0, sizeof(*timing));

 	timing->pixclock = mode->clock * 1000;
 	timing->refresh = drm_mode_vrefresh(mode);

 	timing->xres = mode->hdisplay;
 	timing->right_margin = mode->hsync_start - mode->hdisplay;
 	timing->hsync_len = mode->hsync_end - mode->hsync_start;
 	timing->left_margin = mode->htotal - mode->hsync_end;

 	timing->yres = mode->vdisplay;
 	timing->lower_margin = mode->vsync_start - mode->vdisplay;
 	timing->vsync_len = mode->vsync_end - mode->vsync_start;
 	timing->upper_margin = mode->vtotal - mode->vsync_end;

 	if (mode->flags & DRM_MODE_FLAG_INTERLACE)
 		timing->vmode = FB_VMODE_INTERLACED;
 	else
 		timing->vmode = FB_VMODE_NONINTERLACED;

 	if (mode->flags & DRM_MODE_FLAG_DBLSCAN)
 		timing->vmode |= FB_VMODE_DOUBLE;
 }

 static int exynos_drm_connector_get_modes(struct drm_connector *connector)
 {
 	struct exynos_drm_connector *exynos_connector =
 					to_exynos_connector(connector);
 	struct exynos_drm_manager *manager = exynos_connector->manager;
 	struct exynos_drm_display_ops *display_ops = manager->display_ops;
 	struct edid *edid = NULL;
 	unsigned int count = 0;
 	int ret;

 	DRM_DEBUG_KMS("%s\n", __FILE__);

 	if (!display_ops) {
 		DRM_DEBUG_KMS("display_ops is null.\n");
 		return 0;
 	}

 	/*
 	 * if get_edid() exists then get_edid() callback of hdmi side
 	 * is called to get edid data through i2c interface else
 	 * get timing from the FIMD driver(display controller).
 	 *
 	 * P.S. in case of lcd panel, count is always 1 if success
 	 * because lcd panel has only one mode.
 	 */
 	if (display_ops->get_edid) {
 		edid = display_ops->get_edid(manager->dev, connector);
 		if (IS_ERR_OR_NULL(edid)) {
 			ret = PTR_ERR(edid);
 			edid = NULL;
 			DRM_ERROR("Panel operation get_edid failed %d\n", ret);
 			goto out;
 		}

 		count = drm_add_edid_modes(connector, edid);
 		if (!count) {
 			DRM_ERROR("Add edid modes failed %d\n", count);
 			goto out;
 		}

 		drm_mode_connector_update_edid_property(connector, edid);
 	} else {
 		struct exynos_drm_panel_info *panel;
 		struct drm_display_mode *mode = drm_mode_create(connector->dev);
 		if (!mode) {
 			DRM_ERROR("failed to create a new display mode.\n");
 			return 0;
 		}

 		if (display_ops->get_panel)
 			panel = display_ops->get_panel(manager->dev);
 		else {
 			drm_mode_destroy(connector->dev, mode);
 			return 0;
 		}

 		convert_to_display_mode(mode, panel);
 		connector->display_info.width_mm = mode->width_mm;
 		connector->display_info.height_mm = mode->height_mm;

 		mode->type = DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED;
 		drm_mode_set_name(mode);
 		drm_mode_probed_add(connector, mode);

 		count = 1;
 	}

 out:
 	kfree(edid);
 	return count;
 }

 static int exynos_drm_connector_mode_valid(struct drm_connector *connector,
 					    struct drm_display_mode *mode)
 {
 	struct exynos_drm_connector *exynos_connector =
 					to_exynos_connector(connector);
 	struct exynos_drm_manager *manager = exynos_connector->manager;
 	struct exynos_drm_display_ops *display_ops = manager->display_ops;
 	struct fb_videomode timing;
 	int ret = MODE_BAD;

 	DRM_DEBUG_KMS("%s\n", __FILE__);

 	convert_to_video_timing(&timing, mode);

 	if (display_ops && display_ops->check_timing)
 		if (!display_ops->check_timing(manager->dev, (void *)&timing))
 			ret = MODE_OK;

 	return ret;
 }

 struct drm_encoder *exynos_drm_best_encoder(struct drm_connector *connector)
 {
 	struct drm_device *dev = connector->dev;
 	struct exynos_drm_connector *exynos_connector =
 					to_exynos_connector(connector);
 	struct drm_mode_object *obj;
 	struct drm_encoder *encoder;

 	DRM_DEBUG_KMS("%s\n", __FILE__);

 	obj = drm_mode_object_find(dev, exynos_connector->encoder_id,
 				   DRM_MODE_OBJECT_ENCODER);
 	if (!obj) {
 		DRM_DEBUG_KMS("Unknown ENCODER ID %d\n",
 				exynos_connector->encoder_id);
 		return NULL;
 	}

 	encoder = obj_to_encoder(obj);

 	return encoder;
 }

 static struct drm_connector_helper_funcs exynos_connector_helper_funcs = {
 	.get_modes	= exynos_drm_connector_get_modes,
 	.mode_valid	= exynos_drm_connector_mode_valid,
 	.best_encoder	= exynos_drm_best_encoder,
 };

 void exynos_drm_display_power(struct drm_connector *connector, int mode)
 {
 	struct drm_encoder *encoder = exynos_drm_best_encoder(connector);
 	struct exynos_drm_connector *exynos_connector;
 	struct exynos_drm_manager *manager = exynos_drm_get_manager(encoder);
 	struct exynos_drm_display_ops *display_ops = manager->display_ops;

 	exynos_connector = to_exynos_connector(connector);

 	if (exynos_connector->dpms == mode) {
 		DRM_DEBUG_KMS("desired dpms mode is same as previous one.\n");
 		return;
 	}

 	if (display_ops && display_ops->power_on)
 		display_ops->power_on(manager->dev, mode);

 	exynos_connector->dpms = mode;
 }

 static void exynos_drm_connector_dpms(struct drm_connector *connector,
 					int mode)
 {
 	DRM_DEBUG_KMS("%s\n", __FILE__);

 	/*
 	 * in case that drm_crtc_helper_set_mode() is called,
 	 * encoder/crtc->funcs->dpms() will be just returned
 	 * because they already were DRM_MODE_DPMS_ON so only
 	 * exynos_drm_display_power() will be called.
 	 */
 	drm_helper_connector_dpms(connector, mode);

 	exynos_drm_display_power(connector, mode);

 }

 static int exynos_drm_connector_fill_modes(struct drm_connector *connector,
 				unsigned int max_width, unsigned int max_height)
 {
 	struct exynos_drm_connector *exynos_connector =
 					to_exynos_connector(connector);
 	struct exynos_drm_manager *manager = exynos_connector->manager;
 	struct exynos_drm_manager_ops *ops = manager->ops;
 	unsigned int width, height;

 	width = max_width;
 	height = max_height;

 	/*
 	 * if specific driver want to find desired_mode using maxmum
 	 * resolution then get max width and height from that driver.
 	 */
 	if (ops && ops->get_max_resol)
 		ops->get_max_resol(manager->dev, &width, &height);

 	return drm_helper_probe_single_connector_modes(connector, width,
 							height);
 }

 /* get detection status of display device. */
 static enum drm_connector_status
 exynos_drm_connector_detect(struct drm_connector *connector, bool force)
 {
 	struct exynos_drm_connector *exynos_connector =
 					to_exynos_connector(connector);
 	struct exynos_drm_manager *manager = exynos_connector->manager;
 	struct exynos_drm_display_ops *display_ops =
 					manager->display_ops;
 	enum drm_connector_status status = connector_status_disconnected;

 	DRM_DEBUG_KMS("%s\n", __FILE__);

 	if (display_ops && display_ops->is_connected) {
 		if (display_ops->is_connected(manager->dev))
 			status = connector_status_connected;
 		else
 			status = connector_status_disconnected;
 	}

 	return status;
 }

 static void exynos_drm_connector_destroy(struct drm_connector *connector)
 {
 	struct exynos_drm_connector *exynos_connector =
 		to_exynos_connector(connector);

 	DRM_DEBUG_KMS("%s\n", __FILE__);

 	drm_sysfs_connector_remove(connector);
 	drm_connector_cleanup(connector);
 	kfree(exynos_connector);
 }

 static struct drm_connector_funcs exynos_connector_funcs = {
 	.dpms		= exynos_drm_connector_dpms,
 	.fill_modes	= exynos_drm_connector_fill_modes,
 	.detect		= exynos_drm_connector_detect,
 	.destroy	= exynos_drm_connector_destroy,
 };

 struct drm_connector *exynos_drm_connector_create(struct drm_device *dev,
 						   struct drm_encoder *encoder)
 {
 	struct exynos_drm_connector *exynos_connector;
 	struct exynos_drm_manager *manager = exynos_drm_get_manager(encoder);
 	struct drm_connector *connector;
 	int type;
 	int err;

 	DRM_DEBUG_KMS("%s\n", __FILE__);

 	exynos_connector = kzalloc(sizeof(*exynos_connector), GFP_KERNEL);
 	if (!exynos_connector) {
 		DRM_ERROR("failed to allocate connector\n");
 		return NULL;
 	}

 	connector = &exynos_connector->drm_connector;

 	switch (manager->display_ops->type) {
 	case EXYNOS_DISPLAY_TYPE_HDMI:
 		type = DRM_MODE_CONNECTOR_HDMIA;
 		connector->interlace_allowed = true;
 		connector->polled = DRM_CONNECTOR_POLL_HPD;
 		break;
 	case EXYNOS_DISPLAY_TYPE_VIDI:
 		type = DRM_MODE_CONNECTOR_VIRTUAL;
 		connector->polled = DRM_CONNECTOR_POLL_HPD;
 		break;
 	default:
 		type = DRM_MODE_CONNECTOR_Unknown;
 		break;
 	}

 	drm_connector_init(dev, connector, &exynos_connector_funcs, type);
 	drm_connector_helper_add(connector, &exynos_connector_helper_funcs);

 	err = drm_sysfs_connector_add(connector);
 	if (err)
 		goto err_connector;

 	exynos_connector->encoder_id = encoder->base.id;
 	exynos_connector->manager = manager;
 	exynos_connector->dpms = DRM_MODE_DPMS_OFF;
 	connector->dpms = DRM_MODE_DPMS_OFF;
 	connector->encoder = encoder;

 	err = drm_mode_connector_attach_encoder(connector, encoder);
 	if (err) {
 		DRM_ERROR("failed to attach a connector to a encoder\n");
 		goto err_sysfs;
 	}

 	DRM_DEBUG_KMS("connector has been created\n");

 	return connector;

 err_sysfs:
 	drm_sysfs_connector_remove(connector);
 err_connector:
 	drm_connector_cleanup(connector);
 	kfree(exynos_connector);
 	return NULL;
 }
	/*
	* Copyright (c) 2011 Samsung Electronics Co., Ltd.
	* Authors:
	* Inki Dae <inki.dae@samsung.com>
	* Joonyoung Shim <jy0922.shim@samsung.com>
	* Seung-Woo Kim <sw0312.kim@samsung.com>
	*
	* This program is free software; you can redistribute it and/or modify it
	* under the terms of the GNU General Public License as published by the
	* Free Software Foundation; either version 2 of the License, or (at your
	* option) any later version.
	*/

	#include <drm/drmP.h>
	#include <drm/drm_crtc_helper.h>

	#include <drm/exynos_drm.h>
	#include "exynos_drm_drv.h"
	#include "exynos_drm_encoder.h"

	#define to_exynos_connector(x) container_of(x, struct exynos_drm_connector,\
	drm_connector)

	struct exynos_drm_connector {
	struct drm_connector drm_connector;
	uint32_t encoder_id;
	struct exynos_drm_manager *manager;
	uint32_t dpms;
	};

	/* convert exynos_video_timings to drm_display_mode */
	static inline void
	convert_to_display_mode(struct drm_display_mode *mode,
	struct exynos_drm_panel_info *panel)
	{
	struct fb_videomode *timing = &panel->timing;
	DRM_DEBUG_KMS("%s\n", __FILE__);

	mode->clock = timing->pixclock / 1000;
	mode->vrefresh = timing->refresh;

	mode->hdisplay = timing->xres;
	mode->hsync_start = mode->hdisplay + timing->right_margin;
	mode->hsync_end = mode->hsync_start + timing->hsync_len;
	mode->htotal = mode->hsync_end + timing->left_margin;

	mode->vdisplay = timing->yres;
	mode->vsync_start = mode->vdisplay + timing->lower_margin;
	mode->vsync_end = mode->vsync_start + timing->vsync_len;
	mode->vtotal = mode->vsync_end + timing->upper_margin;
	mode->width_mm = panel->width_mm;
	mode->height_mm = panel->height_mm;

	if (timing->vmode & FB_VMODE_INTERLACED)
	mode->flags \|= DRM_MODE_FLAG_INTERLACE;

	if (timing->vmode & FB_VMODE_DOUBLE)
	mode->flags \|= DRM_MODE_FLAG_DBLSCAN;
	}

	/* convert drm_display_mode to exynos_video_timings */
	static inline void
	convert_to_video_timing(struct fb_videomode *timing,
	struct drm_display_mode *mode)
	{
	DRM_DEBUG_KMS("%s\n", __FILE__);

	memset(timing, 0, sizeof(*timing));

	timing->pixclock = mode->clock * 1000;
	timing->refresh = drm_mode_vrefresh(mode);

	timing->xres = mode->hdisplay;
	timing->right_margin = mode->hsync_start - mode->hdisplay;
	timing->hsync_len = mode->hsync_end - mode->hsync_start;
	timing->left_margin = mode->htotal - mode->hsync_end;

	timing->yres = mode->vdisplay;
	timing->lower_margin = mode->vsync_start - mode->vdisplay;
	timing->vsync_len = mode->vsync_end - mode->vsync_start;
	timing->upper_margin = mode->vtotal - mode->vsync_end;

	if (mode->flags & DRM_MODE_FLAG_INTERLACE)
	timing->vmode = FB_VMODE_INTERLACED;
	else
	timing->vmode = FB_VMODE_NONINTERLACED;

	if (mode->flags & DRM_MODE_FLAG_DBLSCAN)
	timing->vmode \|= FB_VMODE_DOUBLE;
	}

	static int exynos_drm_connector_get_modes(struct drm_connector *connector)
	{
	struct exynos_drm_connector *exynos_connector =
	to_exynos_connector(connector);
	struct exynos_drm_manager *manager = exynos_connector->manager;
	struct exynos_drm_display_ops *display_ops = manager->display_ops;
	struct edid *edid = NULL;
	unsigned int count = 0;
	int ret;

	DRM_DEBUG_KMS("%s\n", __FILE__);

	if (!display_ops) {
	DRM_DEBUG_KMS("display_ops is null.\n");
	return 0;
	}

	/*
	* if get_edid() exists then get_edid() callback of hdmi side
	* is called to get edid data through i2c interface else
	* get timing from the FIMD driver(display controller).
	*
	* P.S. in case of lcd panel, count is always 1 if success
	* because lcd panel has only one mode.
	*/
	if (display_ops->get_edid) {
	edid = display_ops->get_edid(manager->dev, connector);
	if (IS_ERR_OR_NULL(edid)) {
	ret = PTR_ERR(edid);
	edid = NULL;
	DRM_ERROR("Panel operation get_edid failed %d\n", ret);
	goto out;
	}

	count = drm_add_edid_modes(connector, edid);
	if (!count) {
	DRM_ERROR("Add edid modes failed %d\n", count);
	goto out;
	}

	drm_mode_connector_update_edid_property(connector, edid);
	} else {
	struct exynos_drm_panel_info *panel;
	struct drm_display_mode *mode = drm_mode_create(connector->dev);
	if (!mode) {
	DRM_ERROR("failed to create a new display mode.\n");
	return 0;
	}

	if (display_ops->get_panel)
	panel = display_ops->get_panel(manager->dev);
	else {
	drm_mode_destroy(connector->dev, mode);
	return 0;
	}

	convert_to_display_mode(mode, panel);
	connector->display_info.width_mm = mode->width_mm;
	connector->display_info.height_mm = mode->height_mm;

	mode->type = DRM_MODE_TYPE_DRIVER \| DRM_MODE_TYPE_PREFERRED;
	drm_mode_set_name(mode);
	drm_mode_probed_add(connector, mode);

	count = 1;
	}

	out:
	kfree(edid);
	return count;
	}

	static int exynos_drm_connector_mode_valid(struct drm_connector *connector,
	struct drm_display_mode *mode)
	{
	struct exynos_drm_connector *exynos_connector =
	to_exynos_connector(connector);
	struct exynos_drm_manager *manager = exynos_connector->manager;
	struct exynos_drm_display_ops *display_ops = manager->display_ops;
	struct fb_videomode timing;
	int ret = MODE_BAD;

	DRM_DEBUG_KMS("%s\n", __FILE__);

	convert_to_video_timing(&timing, mode);

	if (display_ops && display_ops->check_timing)
	if (!display_ops->check_timing(manager->dev, (void *)&timing))
	ret = MODE_OK;

	return ret;
	}

	struct drm_encoder exynos_drm_best_encoder(struct drm_connector connector)
	{
	struct drm_device *dev = connector->dev;
	struct exynos_drm_connector *exynos_connector =
	to_exynos_connector(connector);
	struct drm_mode_object *obj;
	struct drm_encoder *encoder;

	DRM_DEBUG_KMS("%s\n", __FILE__);

	obj = drm_mode_object_find(dev, exynos_connector->encoder_id,
	DRM_MODE_OBJECT_ENCODER);
	if (!obj) {
	DRM_DEBUG_KMS("Unknown ENCODER ID %d\n",
	exynos_connector->encoder_id);
	return NULL;
	}

	encoder = obj_to_encoder(obj);

	return encoder;
	}

	static struct drm_connector_helper_funcs exynos_connector_helper_funcs = {
	.get_modes = exynos_drm_connector_get_modes,
	.mode_valid = exynos_drm_connector_mode_valid,
	.best_encoder = exynos_drm_best_encoder,
	};

	void exynos_drm_display_power(struct drm_connector *connector, int mode)
	{
	struct drm_encoder *encoder = exynos_drm_best_encoder(connector);
	struct exynos_drm_connector *exynos_connector;
	struct exynos_drm_manager *manager = exynos_drm_get_manager(encoder);
	struct exynos_drm_display_ops *display_ops = manager->display_ops;

	exynos_connector = to_exynos_connector(connector);

	if (exynos_connector->dpms == mode) {
	DRM_DEBUG_KMS("desired dpms mode is same as previous one.\n");
	return;
	}

	if (display_ops && display_ops->power_on)
	display_ops->power_on(manager->dev, mode);

	exynos_connector->dpms = mode;
	}

	static void exynos_drm_connector_dpms(struct drm_connector *connector,
	int mode)
	{
	DRM_DEBUG_KMS("%s\n", __FILE__);

	/*
	* in case that drm_crtc_helper_set_mode() is called,
	* encoder/crtc->funcs->dpms() will be just returned
	* because they already were DRM_MODE_DPMS_ON so only
	* exynos_drm_display_power() will be called.
	*/
	drm_helper_connector_dpms(connector, mode);

	exynos_drm_display_power(connector, mode);

	}

	static int exynos_drm_connector_fill_modes(struct drm_connector *connector,
	unsigned int max_width, unsigned int max_height)
	{
	struct exynos_drm_connector *exynos_connector =
	to_exynos_connector(connector);
	struct exynos_drm_manager *manager = exynos_connector->manager;
	struct exynos_drm_manager_ops *ops = manager->ops;
	unsigned int width, height;

	width = max_width;
	height = max_height;

	/*
	* if specific driver want to find desired_mode using maxmum
	* resolution then get max width and height from that driver.
	*/
	if (ops && ops->get_max_resol)
	ops->get_max_resol(manager->dev, &width, &height);

	return drm_helper_probe_single_connector_modes(connector, width,
	height);
	}

	/* get detection status of display device. */
	static enum drm_connector_status
	exynos_drm_connector_detect(struct drm_connector *connector, bool force)
	{
	struct exynos_drm_connector *exynos_connector =
	to_exynos_connector(connector);
	struct exynos_drm_manager *manager = exynos_connector->manager;
	struct exynos_drm_display_ops *display_ops =
	manager->display_ops;
	enum drm_connector_status status = connector_status_disconnected;

	DRM_DEBUG_KMS("%s\n", __FILE__);

	if (display_ops && display_ops->is_connected) {
	if (display_ops->is_connected(manager->dev))
	status = connector_status_connected;
	else
	status = connector_status_disconnected;
	}

	return status;
	}

	static void exynos_drm_connector_destroy(struct drm_connector *connector)
	{
	struct exynos_drm_connector *exynos_connector =
	to_exynos_connector(connector);

	DRM_DEBUG_KMS("%s\n", __FILE__);

	drm_sysfs_connector_remove(connector);
	drm_connector_cleanup(connector);
	kfree(exynos_connector);
	}

	static struct drm_connector_funcs exynos_connector_funcs = {
	.dpms = exynos_drm_connector_dpms,
	.fill_modes = exynos_drm_connector_fill_modes,
	.detect = exynos_drm_connector_detect,
	.destroy = exynos_drm_connector_destroy,
	};

	struct drm_connector exynos_drm_connector_create(struct drm_device dev,
	struct drm_encoder *encoder)
	{
	struct exynos_drm_connector *exynos_connector;
	struct exynos_drm_manager *manager = exynos_drm_get_manager(encoder);
	struct drm_connector *connector;
	int type;
	int err;

	DRM_DEBUG_KMS("%s\n", __FILE__);

	exynos_connector = kzalloc(sizeof(*exynos_connector), GFP_KERNEL);
	if (!exynos_connector) {
	DRM_ERROR("failed to allocate connector\n");
	return NULL;
	}

	connector = &exynos_connector->drm_connector;

	switch (manager->display_ops->type) {
	case EXYNOS_DISPLAY_TYPE_HDMI:
	type = DRM_MODE_CONNECTOR_HDMIA;
	connector->interlace_allowed = true;
	connector->polled = DRM_CONNECTOR_POLL_HPD;
	break;
	case EXYNOS_DISPLAY_TYPE_VIDI:
	type = DRM_MODE_CONNECTOR_VIRTUAL;
	connector->polled = DRM_CONNECTOR_POLL_HPD;
	break;
	default:
	type = DRM_MODE_CONNECTOR_Unknown;
	break;
	}

	drm_connector_init(dev, connector, &exynos_connector_funcs, type);
	drm_connector_helper_add(connector, &exynos_connector_helper_funcs);

	err = drm_sysfs_connector_add(connector);
	if (err)
	goto err_connector;

	exynos_connector->encoder_id = encoder->base.id;
	exynos_connector->manager = manager;
	exynos_connector->dpms = DRM_MODE_DPMS_OFF;
	connector->dpms = DRM_MODE_DPMS_OFF;
	connector->encoder = encoder;

	err = drm_mode_connector_attach_encoder(connector, encoder);
	if (err) {
	DRM_ERROR("failed to attach a connector to a encoder\n");
	goto err_sysfs;
	}

	DRM_DEBUG_KMS("connector has been created\n");

	return connector;

	err_sysfs:
	drm_sysfs_connector_remove(connector);
	err_connector:
	drm_connector_cleanup(connector);
	kfree(exynos_connector);
	return NULL;
	}