commit e5bc49ba7439b9726006d031d440cba96819f0f8
author Oleg Nesterov <oleg@redhat.com> Thu Mar 12 14:31:28 2009 -0700
committer Linus Torvalds <torvalds@linux-foundation.org> Thu Mar 12 16:20:23 2009 -0700
tree 103c02a297e4c7ba3ba1fd3c90a6bd2d6687f511
parent 8d0df7a3d1ecbaf5d5602a59055c8ca993855bed

pipe_rdwr_fasync: fix the error handling to prevent the leak/crash

If the second fasync_helper() fails, pipe_rdwr_fasync() returns the error
but leaves the file on ->fasync_readers.

This was always wrong, but since 233e70f4228e78eb2f80dc6650f65d3ae3dbf17c
"saner FASYNC handling on file close" we have the new problem.  Because in
this case setfl() doesn't set FASYNC bit, __fput() will not do
->fasync(0), and we leak fasync_struct with ->fa_file pointing to the
freed file.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Cc: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: Jonathan Corbet <corbet@lwn.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>