commit e433430a0ca9cc1b851a83ac3b305e955b64880a
author Steffen Klassert <steffen.klassert@secunet.com> Tue Mar 15 21:09:32 2011 +0000
committer David S. Miller <davem@davemloft.net> Sun Mar 27 17:55:01 2011 -0700
tree 129e0c5db7e5643352ac55a920b5d6c5ef65fb66
parent 3bc07321ccc236f693ce1b6a8786f0a2e38bb87e

dst: Clone child entry in skb_dst_pop

We clone the child entry in skb_dst_pop before we call
skb_dst_drop(). Otherwise we might kill the child right
before we return it to the caller.

Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

include/net/dst.h

diff --git a/include/net/dst.h b/include/net/dst.h
index 2a46cba..75b95df 100644
--- a/include/net/dst.h
+++ b/include/net/dst.h
@@ -345,7 +345,7 @@
 
 static inline struct dst_entry *skb_dst_pop(struct sk_buff *skb)
 {
-	struct dst_entry *child = skb_dst(skb)->child;
+	struct dst_entry *child = dst_clone(skb_dst(skb)->child);
 
 	skb_dst_drop(skb);
 	return child;