)]}' { "commit": "e324654294907a420ab3773efe8849a935f37bf0", "tree": "478a948e76d8f660b0f3b898c1094df5b172e433", "parents": [ "9d2aa8c7961ae9af5f75af2dc171dd4e4f441e89" ], "author": { "name": "Masahiro Yamada", "email": "yamada.masahiro@socionext.com", "time": "Mon Nov 16 12:06:10 2015 +0900" }, "committer": { "name": "Arnd Bergmann", "email": "arnd@arndb.de", "time": "Tue Dec 01 22:44:51 2015 +0100" }, "message": "ARM: use \"depends on\" for SoC configs instead of \"if\" after prompt\n\nMany ARM sub-architectures use prompts followed by \"if\" conditional,\nbut it is wrong.\n\nPlease notice the difference between\n\n config ARCH_FOO\n bool \"Foo SoCs\" if ARCH_MULTI_V7\n\nand\n\n config ARCH_FOO\n bool \"Foo SoCs\"\n depends on ARCH_MULTI_V7\n\nThese two are *not* equivalent!\n\nIn the former statement, it is not ARCH_FOO, but its prompt that\ndepends on ARCH_MULTI_V7. So, it is completely valid that ARCH_FOO\nis selected by another, but ARCH_MULTI_V7 is still disabled. As it is\nnot unmet dependency, Kconfig never warns. This is probably not what\nyou want.\n\nThe former should be used only when you need to do so, and you really\nunderstand what you are doing. (In most cases, it should be wrong!)\n\nFor enabling/disabling sub-architectures, the latter is always correct.\n\nAs a good side effect, this commit fixes some entries over 80 columns\n(mach-imx, mach-integrator, mach-mbevu).\n\n[Arnd: I note that there is not really a bug here, according to\n the discussion that followed, but I can see value in being consistent\n and in making the lines shorter]\n\nSigned-off-by: Masahiro Yamada \u003cyamada.masahiro@socionext.com\u003e\nAcked-by: Maxime Ripard \u003cmaxime.ripard@free-electrons.com\u003e\nAcked-by: Nicolas Ferre \u003cnicolas.ferre@atmel.com\u003e\nAcked-by: Heiko Stuebner \u003cheiko@sntech.de\u003e\nAcked-by: Patrice Chotard \u003cpatrice.chotard@st.com\u003e\nAcked-by: Liviu Dudau \u003cLiviu.Dudau@arm.com\u003e\nAcked-by: Krzysztof Kozlowski \u003ck.kozlowski@samsung.com\u003e\nAcked-by: Jun Nie \u003cjun.nie@linaro.org\u003e\nAcked-by: Matthias Brugger \u003cmatthias.bgg@gmail.com\u003e\nAcked-by: Simon Horman \u003chorms+renesas@verge.net.au\u003e\nAcked-by: Gregory CLEMENT \u003cgregory.clement@free-electrons.com\u003e\nAcked-by: Shawn Guo \u003cshawnguo@kernel.org\u003e\nAcked-by: Sebastian Hesselbarth \u003csebastian.hesselbarth@gmail.com\u003e\nAcked-by: Thierry Reding \u003ctreding@nvidia.com\u003e\nAcked-by: Krzysztof Halasa \u003ckhc@piap.pl\u003e\nAcked-by: Maxime Coquelin \u003cmaxime.coquelin@st.com\u003e\nSigned-off-by: Arnd Bergmann \u003carnd@arndb.de\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "34e1569a11ee322a0a020bdfe0c9b801b6b58c12", "old_mode": 33188, "old_path": "arch/arm/Kconfig", "new_id": "e803304f4afa8d9aa1bd1fafec2c49b2e47938d3", "new_mode": 33188, "new_path": "arch/arm/Kconfig" }, { "type": "modify", "old_id": "2c44b930505a27d49bfe743f9ede46e8cbe7dfe5", "old_mode": 33188, "old_path": "arch/arm/mach-alpine/Kconfig", "new_id": "5c2d54f59f537de391c9425102aca0092d3d3bb1", "new_mode": 33188, "new_path": "arch/arm/mach-alpine/Kconfig" }, { "type": "modify", "old_id": "92673006e55c410ad27f60675c8e74bbf1433861", "old_mode": 33188, "old_path": "arch/arm/mach-at91/Kconfig", "new_id": "8649f033e2bfb6bef1b7abac466853830cec67f6", "new_mode": 33188, "new_path": "arch/arm/mach-at91/Kconfig" }, { "type": "modify", "old_id": "8be7e0ae1922998ee7871e668662a9f495b8e239", "old_mode": 33188, "old_path": "arch/arm/mach-axxia/Kconfig", "new_id": "6c6d5e76565b71afc0d7b7a0e21e86da2188fec1", "new_mode": 33188, "new_path": "arch/arm/mach-axxia/Kconfig" }, { "type": "modify", "old_id": "8c53c55be1feb318e84e2c2aba475b42646527c2", "old_mode": 33188, "old_path": "arch/arm/mach-bcm/Kconfig", "new_id": "77116dcac01a10e1028a4d6e21cbb5359f2322e0", "new_mode": 33188, "new_path": "arch/arm/mach-bcm/Kconfig" }, { "type": "modify", "old_id": "742d53a5f7f94fc8ee58ed3fdd69a2e4c49f75b6", "old_mode": 33188, "old_path": "arch/arm/mach-berlin/Kconfig", "new_id": "ffbfa0bd091b0022a22ba1d71a8d5f3f1605e85b", "new_mode": 33188, "new_path": "arch/arm/mach-berlin/Kconfig" }, { "type": "modify", "old_id": "3c22a1990ecd0ff2830dcb8bdf6b33a88685bda7", "old_mode": 33188, "old_path": "arch/arm/mach-cns3xxx/Kconfig", "new_id": "eb14a0ff0093848faee161b9f7ae5749e1b3ae86", "new_mode": 33188, "new_path": "arch/arm/mach-cns3xxx/Kconfig" }, { "type": "modify", "old_id": "3a10f1a8317ae7a053ed997da88a06ddd5311b57", "old_mode": 33188, "old_path": "arch/arm/mach-exynos/Kconfig", "new_id": "49e8dcf37206e0c690d6b8190b92241c7ca20923", "new_mode": 33188, "new_path": "arch/arm/mach-exynos/Kconfig" }, { "type": "modify", "old_id": "31aa866c33171aa107075e39d03551824a7fb51a", "old_mode": 33188, "old_path": "arch/arm/mach-highbank/Kconfig", "new_id": "81110ec34226232ce1c33921804019925d9478d4", "new_mode": 33188, "new_path": "arch/arm/mach-highbank/Kconfig" }, { "type": "modify", "old_id": "83061ad0e28232cfe227d21ccf3c8905f2b909b3", "old_mode": 33188, "old_path": "arch/arm/mach-hisi/Kconfig", "new_id": "a3b091a4d344a43d2a903b5ffaaa672bf742db4a", "new_mode": 33188, "new_path": "arch/arm/mach-hisi/Kconfig" }, { "type": "modify", "old_id": "8ceda2844c4ffee32405d85a48c8bdcd86272591", "old_mode": 33188, "old_path": "arch/arm/mach-imx/Kconfig", "new_id": "0ac180f7b3304a92e607502ca37a6e1104de4996", "new_mode": 33188, "new_path": "arch/arm/mach-imx/Kconfig" }, { "type": "modify", "old_id": "02d083489a2641ac5f9d71ca390e53a4965c1570", "old_mode": 33188, "old_path": "arch/arm/mach-integrator/Kconfig", "new_id": "2fa9d11c9d141625f088332bf89fecf2d645f1de", "new_mode": 33188, "new_path": "arch/arm/mach-integrator/Kconfig" }, { "type": "modify", "old_id": "aeece17e5ceaa4da09276c38cab1cf2ce24d9311", "old_mode": 33188, "old_path": "arch/arm/mach-mediatek/Kconfig", "new_id": "0abcc51afff5303bce4cd054251c09be2b10a4ae", "new_mode": 33188, "new_path": "arch/arm/mach-mediatek/Kconfig" }, { "type": "modify", "old_id": "5d56f86ae1a4b1c96871e05c69eafd5bac5f7b26", "old_mode": 33188, "old_path": "arch/arm/mach-meson/Kconfig", "new_id": "31bdd91098b637fa4f9314f649ada051e89a7f95", "new_mode": 33188, "new_path": "arch/arm/mach-meson/Kconfig" }, { "type": "modify", "old_id": "f49328c39befe73f91d20380272f65bff9bae4f2", "old_mode": 33188, "old_path": "arch/arm/mach-moxart/Kconfig", "new_id": "180d9d2167195936ccb2062b1e8035a8adefef78", "new_mode": 33188, "new_path": "arch/arm/mach-moxart/Kconfig" }, { "type": "modify", "old_id": "e20fc4178b15b029f098690f0bc9420be170c141", "old_mode": 33188, "old_path": "arch/arm/mach-mvebu/Kconfig", "new_id": "64e3d2ce9a076650b7eb3056cd4194419ae7d3dd", "new_mode": 33188, "new_path": "arch/arm/mach-mvebu/Kconfig" }, { "type": "modify", "old_id": "62240f69b4ee8b1e62c0a94cc936e6fdcb52bd5b", "old_mode": 33188, "old_path": "arch/arm/mach-picoxcell/Kconfig", "new_id": "aef92ba0eacd9bf5e04611814739b4032bedf2ab", "new_mode": 33188, "new_path": "arch/arm/mach-picoxcell/Kconfig" }, { "type": "modify", "old_id": "9ab8932403e5dede46f37dabfd5d8658b01a405e", "old_mode": 33188, "old_path": "arch/arm/mach-prima2/Kconfig", "new_id": "f998eb1c698ec69bb18735c60ce4660f680db272", "new_mode": 33188, "new_path": "arch/arm/mach-prima2/Kconfig" }, { "type": "modify", "old_id": "2256cd1e25d156cfd7e40d6c86cd8a9a1b104997", "old_mode": 33188, "old_path": "arch/arm/mach-qcom/Kconfig", "new_id": "73494500b51cbb79b2a1aa025f5ad54f5cf60276", "new_mode": 33188, "new_path": "arch/arm/mach-qcom/Kconfig" }, { "type": "modify", "old_id": "ae4eb7cc4bcc5a1c5dffa8a26f98e5c58b6cf3f8", "old_mode": 33188, "old_path": "arch/arm/mach-rockchip/Kconfig", "new_id": "cef42fd886d1064d514b20482dce7e41a1a0aaeb", "new_mode": 33188, "new_path": "arch/arm/mach-rockchip/Kconfig" }, { "type": "modify", "old_id": "330bfc8fcd52d2c74e796e4bdb1d5d2d90a884e0", "old_mode": 33188, "old_path": "arch/arm/mach-s5pv210/Kconfig", "new_id": "13bc9820ff226cd89d5ff6c75b72220ea6c74adc", "new_mode": 33188, "new_path": "arch/arm/mach-s5pv210/Kconfig" }, { "type": "modify", "old_id": "88734a5e10ca518be58b4217e22adab218e05d62", "old_mode": 33188, "old_path": "arch/arm/mach-shmobile/Kconfig", "new_id": "0f25f8fa269284a96d22e7501a26b6e2bc8cab5c", "new_mode": 33188, "new_path": "arch/arm/mach-shmobile/Kconfig" }, { "type": "modify", "old_id": "90efdeb56be50450dd978e47bbcb9ed5854384d8", "old_mode": 33188, "old_path": "arch/arm/mach-socfpga/Kconfig", "new_id": "d0f62eacf59da510388dd206d2673eb1b6aa84e3", "new_mode": 33188, "new_path": "arch/arm/mach-socfpga/Kconfig" }, { "type": "modify", "old_id": "b6f4bda273b347556c8685c398727d983836a1ac", "old_mode": 33188, "old_path": "arch/arm/mach-spear/Kconfig", "new_id": "ea9ea95630bdb7ee04a638377958a5c429a50ba7", "new_mode": 33188, "new_path": "arch/arm/mach-spear/Kconfig" }, { "type": "modify", "old_id": "125865daaf1719e931cb051b9039292799b8e930", "old_mode": 33188, "old_path": "arch/arm/mach-sti/Kconfig", "new_id": "736abe6d01dcba858793b2d9408a59ed21251763", "new_mode": 33188, "new_path": "arch/arm/mach-sti/Kconfig" }, { "type": "modify", "old_id": "4efe2d43a126b4ca13c42aa08fc67ce11c898d35", "old_mode": 33188, "old_path": "arch/arm/mach-sunxi/Kconfig", "new_id": "c124d658b3506d36d8070bcb4cdf1e22a86ef607", "new_mode": 33188, "new_path": "arch/arm/mach-sunxi/Kconfig" }, { "type": "modify", "old_id": "0fa4c5f8b1beb31abfa6f26745143a1693a8725c", "old_mode": 33188, "old_path": "arch/arm/mach-tegra/Kconfig", "new_id": "a90f3556017fe80ae3d2587e54e063cd619c0e6a", "new_mode": 33188, "new_path": "arch/arm/mach-tegra/Kconfig" }, { "type": "modify", "old_id": "bc51a71394af722a5ba577863cdc28d87d0d61a3", "old_mode": 33188, "old_path": "arch/arm/mach-u300/Kconfig", "new_id": "301a98498453d40915c2292da3d844d38bcce3e5", "new_mode": 33188, "new_path": "arch/arm/mach-u300/Kconfig" }, { "type": "modify", "old_id": "c9ac19b24e5a5da7bbfbf7aa7afcaff34f067e96", "old_mode": 33188, "old_path": "arch/arm/mach-ux500/Kconfig", "new_id": "a5c3373c7f76db116f4e9cfd117e0f818e51094c", "new_mode": 33188, "new_path": "arch/arm/mach-ux500/Kconfig" }, { "type": "modify", "old_id": "10f9389572da2e8a6fb9fb59824f3b8d3fea4c64", "old_mode": 33188, "old_path": "arch/arm/mach-vexpress/Kconfig", "new_id": "398a297b7e0959c08a085e29875320320f95f816", "new_mode": 33188, "new_path": "arch/arm/mach-vexpress/Kconfig" }, { "type": "modify", "old_id": "446334a25cf5c6f0db61a9c10558e6c1e57b7823", "old_mode": 33188, "old_path": "arch/arm/mach-zx/Kconfig", "new_id": "209c97944de22028bdafbcb4f78107bb734335ec", "new_mode": 33188, "new_path": "arch/arm/mach-zx/Kconfig" }, { "type": "modify", "old_id": "78e5e007f52dbc69f49971ce8ff9fdda04e358e3", "old_mode": 33188, "old_path": "arch/arm/mach-zynq/Kconfig", "new_id": "f287667e4fc501835d6518da3e6e6b9b347011b4", "new_mode": 33188, "new_path": "arch/arm/mach-zynq/Kconfig" } ] }