commit c46ca3c8310b61d253a39ff1375ea97912794cd1
author Markus Elfring <elfring@users.sourceforge.net> Tue Dec 02 13:54:00 2014 +0100
committer Grant Likely <grant.likely@linaro.org> Wed Dec 03 23:12:41 2014 +0000
tree c2083c006491b8ad03eed666ff1ce60dd7b62e15
parent 70161ff336674ecfd20614a9c0c61cb17a6e9e83

of: Delete unnecessary check before calling "of_node_put()"

The of_node_put() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Grant Likely <grant.likely@linaro.org>

drivers/of/unittest.c

diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c
index 1807a04..844838e 100644
--- a/drivers/of/unittest.c
+++ b/drivers/of/unittest.c
@@ -516,8 +516,7 @@
 	/* Make sure node names are constructed correctly */
 	selftest((np = of_find_node_by_path("/testcase-data/changeset/n2/n21")),
 		 "'%s' not added\n", n21->full_name);
-	if (np)
-		of_node_put(np);
+	of_node_put(np);
 
 	mutex_lock(&of_mutex);
 	selftest(!of_changeset_revert(&chgset), "revert failed\n");