commit b786c6a98ef6fa81114ba7b9fbfc0d67060775e3
author Jiri Slaby <jirislaby@gmail.com> Sat Jan 17 12:04:36 2009 +0100
committer Ingo Molnar <mingo@elte.hu> Sun Jan 18 20:29:35 2009 +0100
tree bff900158067adba76c14a61499e4d9520463e86
parent fdb6a8f4db813b4e50f4e975efe6be12ba5bf460

relay: fix lock imbalance in relay_late_setup_files

One fail path in relay_late_setup_files() omits
mutex_unlock(&relay_channels_mutex);
Add it.

Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>

kernel/relay.c

diff --git a/kernel/relay.c b/kernel/relay.c
index 09ac200..9d79b78 100644
--- a/kernel/relay.c
+++ b/kernel/relay.c
@@ -663,8 +663,10 @@
 
 	mutex_lock(&relay_channels_mutex);
 	/* Is chan already set up? */
-	if (unlikely(chan->has_base_filename))
+	if (unlikely(chan->has_base_filename)) {
+		mutex_unlock(&relay_channels_mutex);
 		return -EEXIST;
+	}
 	chan->has_base_filename = 1;
 	chan->parent = parent;
 	curr_cpu = get_cpu();