commit 8798a694da59486e4a3ff0abeec183202fb34c20
author Michael Reed <mdr@sgi.com> Fri Oct 09 14:15:59 2009 -0500
committer James Bottomley <James.Bottomley@suse.de> Thu Oct 29 13:03:28 2009 -0400
tree 2410f1f70f7724e41f700c1ec4086f2567208730
parent ad63082626f99651d261ccd8698ce4e997362f7e

[SCSI] scsi_transport_fc: remove invalid BUG_ON

I was doing some large lun count testing with 2.6.31 and hit
a BUG_ON() in fc_timeout_deleted_rport(), and it seems like it
should have been just a matter of time before someone did.

It seems invalid to set port_state under lock, then expect it to
remain set after releasing the lock.  Another thread called
fc_remote_port_add() when the lock was released, changing the
port_state.

This patch removes the BUG_ON and moves the test of the
port_state to inside the host_lock.  It's been running for
several weeks now with no ill effect.

Signed-off-by: Michael Reed <mdr@sgi.com>
Acked-by:  James Smart <james.smart@emulex.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>