commit 6c356634111c5a7a48264d7c9ec28559e4be11a2
author André Goddard Rosa <andre.goddard@gmail.com> Mon Dec 14 18:00:56 2009 -0800
committer Linus Torvalds <torvalds@linux-foundation.org> Tue Dec 15 08:53:29 2009 -0800
tree 580b71e1e3764c4cc92ae9df5275b161c61f3267
parent 0f4f81dce93774a447da3ceb98cce193ef84a3fa

vsprintf: pre-calculate final string length for later use

Signed-off-by: André Goddard Rosa <andre.goddard@gmail.com>
Acked-by: Frederic Weisbecker <fweisbec@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

lib/vsprintf.c

diff --git a/lib/vsprintf.c b/lib/vsprintf.c
index e5ab51f..99747a5 100644
--- a/lib/vsprintf.c
+++ b/lib/vsprintf.c
@@ -1496,13 +1496,14 @@
 		case FORMAT_TYPE_STR: {
 			const char *save_str = va_arg(args, char *);
 			size_t len;
+
 			if ((unsigned long)save_str > (unsigned long)-PAGE_SIZE
 					|| (unsigned long)save_str < PAGE_SIZE)
 				save_str = "(null)";
-			len = strlen(save_str);
-			if (str + len + 1 < end)
-				memcpy(str, save_str, len + 1);
-			str += len + 1;
+			len = strlen(save_str) + 1;
+			if (str + len < end)
+				memcpy(str, save_str, len);
+			str += len;
 			break;
 		}