commit 6512391a30f6b158488e941214541e84473b6bf9
author Colin Ian King <colin.king@canonical.com> Tue Sep 06 09:01:31 2016 +0200
committer Martin Schwidefsky <schwidefsky@de.ibm.com> Tue Sep 06 11:00:00 2016 +0200
tree e9b559bdd5c9ef52136334c54f38c6c45e7d51d7
parent e68f1d4ca99e08652066f40d7778b6007f0149d9

s390/crypto: avoid returning garbage value

Static analysis with cppcheck detected that ret is not initialized
and hence garbage is potentially being returned in the case where
prng_data->ppnows.reseed_counter <= prng_reseed_limit.

Thanks to Martin Schwidefsky for spotting a mistake in my original
fix.

Fixes: 0177db01adf26cf9 ("s390/crypto: simplify return code handling")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>

arch/s390/crypto/prng.c

diff --git a/arch/s390/crypto/prng.c b/arch/s390/crypto/prng.c
index 79e3a1f..9cc050f 100644
--- a/arch/s390/crypto/prng.c
+++ b/arch/s390/crypto/prng.c
@@ -434,7 +434,7 @@
 		memcpy(prng_data->prev, buf, nbytes);
 	}
 
-	return ret;
+	return nbytes;
 }