commit 49e7372063a220651b4f12fa46113559533cafee
author J. Bruce Fields <bfields@redhat.com> Thu Sep 12 09:31:39 2013 -0400
committer J. Bruce Fields <bfields@redhat.com> Tue Oct 29 17:43:52 2013 -0400
tree 5646b5f1a30977b5e31313d47973695662245b9c
parent 956c4fee446c568ad102625da931e259f22c67ee

nfsd: fh_update should error out in unexpected cases

The reporter saw a NULL dereference when a filesystem's ->mknod returned
success but left the dentry negative, and then nfsd tried to dereference
d_inode (in this case because the CREATE was followed by a GETATTR in
the same nfsv4 compound).

fh_update already checks for this and another broken case, but for some
reason it returns success and leaves nfsd trying to soldier on.  If it
failed we'd avoid the crash.  There's only so much we can do with a
buggy filesystem, but it's easy enough to bail out here, so let's do
that.

Reported-by: Antti Tönkyrä <daedalus@pingtimeout.net>
Tested-by: Antti Tönkyrä <daedalus@pingtimeout.net>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>