commit 1ca4b88e7de23f6f86d2009101fe42d5b9dbf3de
author Kinglong Mee <kinglongmee@gmail.com> Thu Jul 09 17:38:26 2015 +0800
committer J. Bruce Fields <bfields@redhat.com> Mon Jul 20 14:58:22 2015 -0400
tree 999d7832f8e06ec7b6fbf255f30998952feeae0c
parent c2227a39a078473115910512aa0f8d53bd915e60

nfsd: Fix a file leak on nfsd4_layout_setlease failure

If nfsd4_layout_setlease fails, nfsd will not put ls->ls_file.

Fix commit c5c707f96f "nfsd: implement pNFS layout recalls".

Signed-off-by: Kinglong Mee <kinglongmee@gmail.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>

fs/nfsd/nfs4layouts.c

diff --git a/fs/nfsd/nfs4layouts.c b/fs/nfsd/nfs4layouts.c
index 6904213..ebf90e4 100644
--- a/fs/nfsd/nfs4layouts.c
+++ b/fs/nfsd/nfs4layouts.c
@@ -212,6 +212,7 @@
 	BUG_ON(!ls->ls_file);
 
 	if (nfsd4_layout_setlease(ls)) {
+		fput(ls->ls_file);
 		put_nfs4_file(fp);
 		kmem_cache_free(nfs4_layout_stateid_cache, ls);
 		return NULL;